Date: Fri, 17 Jan 2003 10:26:10 -0800 From: Will Andrews <will@csociety.org> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: freebsd-current@FreeBSD.ORG Subject: Re: VM_METER no longer defined? Message-ID: <20030117182610.GR30015@procyon.firepipe.net> In-Reply-To: <1042826526.328.24.camel@gyros> References: <XFMail.20030117052330.conrads@cox.net> <3E284083.3030504@btc.adaptec.com> <1042826526.328.24.camel@gyros>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 17, 2003 at 01:02:07PM -0500, Joe Marcus Clarke wrote: > It looks like Matt did this to fix vm.vmtotal. From sys/vm/vm_param.h: > > Make 'sysctl vm.vmtotal' work properly using updated patch from Hiten. > (the patch in the PR was stale). > > It looks to have been replaced by VM_TOTAL. I fixed libgtop[2] by > checking for VM_TOTAL, and using that instead of VM_METER. This seems > to work. Of course, these things can be fixed. But I consider this change gratuitous and it breaks standard compatability rules: deprecate for one major version and remove in the second. I haven't seen any reason why this couldn't be added to vm/vm_param.h: #define VM_METER VM_TOTAL for compatability purposes. This change is way too sudden in an external API (if it's supposed to be internal, then protect it with an #ifdef _KERNEL already!). Regards, -- wca To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030117182610.GR30015>