Date: Tue, 25 Feb 2003 22:45:29 +0100 From: Morten Rodal <morten@rodal.no> To: Maxime Henrion <mux@FreeBSD.ORG> Cc: current@FreeBSD.ORG Subject: Re: patch for the nVidia driver and -CURRENT Message-ID: <20030225214529.GA19651@slurp.rodal.no> In-Reply-To: <20030225182809.GA18565@elvis.mu.org> References: <20030225182809.GA18565@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--pWyiEgJYm5f9v55/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 25, 2003 at 07:28:09PM +0100, Maxime Henrion wrote: [snip a lot of the patch] > @@ -1431,7 +1442,8 @@ > SLIST_FOREACH(at, &sc->alloc_list, list) { > if (offset >=3D at->address && > offset < at->address + at->size) > - return atop(vtophys(offset)); > + *paddr =3D vtophys(offset); > + return 0; > } > =20 > return -1; Should the function return 0 even if the if (offset..) fails? I have no clue about the nvidia kernel driver (or kernel stuff at all) but it seems to me that the only way the function can return -1 is if the list is empty. --=20 Morten Rodal --pWyiEgJYm5f9v55/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+W+P5bWe1Cy11WVsRAvzoAJwJUf9BZnYo8HAA7LekTW1qZXNxKwCgwuZk orchQZABzmFrN3PhNy12ZHE= =hKyn -----END PGP SIGNATURE----- --pWyiEgJYm5f9v55/-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030225214529.GA19651>