Date: Thu, 5 Apr 2012 20:52:44 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: jasone@freebsd.org Cc: current@freebsd.org Subject: Re: contrib/jemalloc Message-ID: <20120405175244.GZ2358@deviant.kiev.zoral.com.ua> In-Reply-To: <431CB493-836B-4DF4-AC42-A7C6ABF7DE3E@canonware.com> References: <431CB493-836B-4DF4-AC42-A7C6ABF7DE3E@canonware.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--+DdorAa6Vvp/ZpQm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 04, 2012 at 09:56:45PM -0700, Jason Evans wrote: > I have the current version of jemalloc integrated into libc as contrib/je= malloc: >=20 > http://people.freebsd.org/~jasone/patches/jemalloc_20120404b.patch > * Are the symbol versioning specifications right, and are the > compatibility symbols for _malloc_options and _malloc_message workable? Why do you manually added __sys_compat() for the symbols ? My reading of the patch shows that you do not change the ABI, and symbols are still at FBSD_1.0 and even in Symbol.map. The 1.3 symbols have different names, without prepended '_' ? Please correct me if I am wrong, but it seems that the __sym_compat() magic is not needed. > * Is the light editing of the jemalloc manual page sufficient? Keeping > the changes minimal will make regular imports less work, but the > result is less tailored to FreeBSD. > Might be, keep existing but somewhat trimmed malloc(3) page as is, but add the unedited man from contrib as jemalloc(3), xreferencing it from malloc(3) ? --+DdorAa6Vvp/ZpQm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk992+wACgkQC3+MBN1Mb4g68QCgwgB3y4OwspigY0IeSWIgZXKo YXUAnAmByJ6qu7e4GxHuCKS5g6xqO3t8 =iu0P -----END PGP SIGNATURE----- --+DdorAa6Vvp/ZpQm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120405175244.GZ2358>