Date: Sat, 24 Aug 2019 21:04:40 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: Michael Butler <imb@protected-networks.net>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: SVN r351457 breaks drm-current Message-ID: <20190824180440.GD71821@kib.kiev.ua> In-Reply-To: <CANCZdfoEoHZHQDiLfQcxKZhvS7Z17PKEnKbksfYx2spUrYxF%2Bw@mail.gmail.com> References: <1ed2692e-9964-58f7-5af9-08fadf65dec7@protected-networks.net> <CANCZdfoEoHZHQDiLfQcxKZhvS7Z17PKEnKbksfYx2spUrYxF%2Bw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 24, 2019 at 11:02:20AM -0600, Warner Losh wrote: > forward declaring struct pcpu; in md_var.h "fixes" this, but I'm not sure > that's the right fix. More correct way to fix it is to include sys/pcpu.h before machine/md_var.h, same as all in-tree consumers of the header do, apparently. But another question is why the driver needs md_var.h, there are no externally usable definitions there. > > Warner > > On Sat, Aug 24, 2019 at 10:35 AM Michael Butler <imb@protected-networks.net> > wrote: > > > As follows .. > > > > Building > > > > /usr/obj/usr/src/amd64.amd64/sys/TOSHI/modules/usr/local/sys/modules/drm-current-kmod/linuxkpi/linux_compat.o > > --- linux_compat.o --- > > In file included from > > > > /usr/local/sys/modules/drm-current-kmod/linuxkpi/gplv2/src/linux_compat.c:5: > > ./machine/md_var.h:61:34: error: declaration of 'struct pcpu' will not > > be visible outside of this function [-Werror,-Wvisibility] > > void amd64_bsp_pcpu_init1(struct pcpu *pc); > > ^ > > ./machine/md_var.h:63:32: error: declaration of 'struct pcpu' will not > > be visible outside of this function [-Werror,-Wvisibility] > > void amd64_bsp_ist_init(struct pcpu *pc); > > ^ > > > > imb > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190824180440.GD71821>