Date: Sat, 14 Dec 2002 16:08:58 -0800 From: "Sam Leffler" <sam@errno.com> To: "Matthew Dillon" <dillon@apollo.backplane.com>, "Maxime Henrion" <mux@FreeBSD.ORG> Cc: "David O'Brien" <obrien@FreeBSD.ORG>, <current@FreeBSD.ORG> Subject: Re: ipfw userland breaks again. Message-ID: <23f401c2a3ce$2a6e7e30$52557f42@errno.com> References: <200212142025.aa99706@salmon.maths.tcd.ie> <200212142038.gBEKcDVv029924@apollo.backplane.com> <20021214204426.GA62058@dragon.nuxi.com> <200212142209.gBEM9D8p002479@apollo.backplane.com> <20021214221252.GF27086@elvis.mu.org> <200212142222.gBEMMqcn002571@apollo.backplane.com> <20021214224524.GG27086@elvis.mu.org> <200212142351.gBENpBVH002931@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> :Now I would really dislike seeing your patch in the tree, since I
> :consider it's a rather crude hack to circumvent the ABI problems of
> :ipfw. As I've already said to luigi in private e-mail (I would be
> :surprised if this hasn't been already discussed in the lists as well),
> :the proper way to fix this problem is to separate the kernel and
> :userland structures of ipfw, and add versioning to the struct.
> :
> :This can be done without even breaking the ABI again, since several
> :pointers in the kernel structures are useless to userland (like the next
> :field) and can be reused to implement structure versioning.
> :
> :Cheers,
> :Maxime
>
> If/when Luigi fixes the ABI problems with IPFW, we can remove
> this 'hack'. Until then, I do not consider the hackiness nature
> of the patch sufficient reason to not put it in. I've been bitten
> by this problem dozens of times, and wasted many hours simply because
> I couldn't get the damn network working, and so have others.
I disagree with committing this hack; keep it as a local mod if you must.
As to the problem; don't wait for Luigi to "fix the ABI problems", do it
yourself. Good things happen when folks are PO'd and won't settle for the
status quo.
Sam
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?23f401c2a3ce$2a6e7e30$52557f42>