Date: Thu, 14 May 2015 07:42:15 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: John-Mark Gurney <jmg@funkthat.com> Cc: Ian Lepore <ian@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, Hans Petter Selasky <hps@selasky.org>, David Chisnall <theraven@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org>, "current@freebsd.org" <current@freebsd.org> Subject: Re: Increase BUFSIZ to 8192 Message-ID: <62511.1431589335@critter.freebsd.dk> In-Reply-To: <20150514072155.GT37063@funkthat.com> References: <20150511230635.GA46991@ivaldir.etoilebsd.net> <20150512032307.GP37063@funkthat.com> <14994.1431412293@critter.freebsd.dk> <20150513080342.GE37063@funkthat.com> <A1224018-7540-4C76-91EF-AEA2655E49A8@FreeBSD.org> <55530CC3.1090204@selasky.org> <1431528249.1221.15.camel@freebsd.org> <CAJ-VmonL9mT4JLqfSefKYiwv5-ecLkx9RZ5=kXt__%2Bs9iO4%2B9Q@mail.gmail.com> <20150513181347.GM37063@funkthat.com> <1431542835.1221.30.camel@freebsd.org> <20150514072155.GT37063@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-------- In message <20150514072155.GT37063@funkthat.com>, John-Mark Gurney writes: >Since you apprently missed my original reply, I said that we shouldn't >abuse BUFSIZ for this work, and that it should be changed in mdXhl.c... Say what ? BUFSIZ is used entirely appropriately in MDXFileChunk(): For reading a file into an algorithm. If in stead of open(2), fopen(3) had been used, the exact same thing would happen, but using malloc space rather than stack space. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?62511.1431589335>