Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Apr 2000 07:45:36 +0200
From:      Poul-Henning Kamp <phk@critter.freebsd.dk>
To:        Donn Miller <dmmiller@cvzoom.net>
Cc:        Will Andrews <andrews@technologist.com>, current@FreeBSD.ORG
Subject:   Re: PATCH: Removal of unneeded <sys/kernel.h> 
Message-ID:  <69167.956900736@critter.freebsd.dk>
In-Reply-To: Your message of "Fri, 28 Apr 2000 01:42:05 EDT." <390924AD.6313EDAA@cvzoom.net> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <390924AD.6313EDAA@cvzoom.net>, Donn Miller writes:
>Will Andrews wrote:
>> 
>> On Wed, Apr 26, 2000 at 11:50:11AM +0200, Poul-Henning Kamp wrote:
>
>> > Comments, tests and reviews please.
>> 
>> Just write a script to check all #include's against their prototypes and
>> have it autogen diffs.
>
>I agree.  I like the automated method better.  What happens if someone
>accidentally commits an additional unnecessary #include after the
>patch has been applied?

I agree too, but nobody has written *that* code yet.

--
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD coreteam member | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69167.956900736>