Date: Tue, 29 Jan 2013 21:17:03 +0200 From: Kimmo Paasiala <kpaasial@gmail.com> To: Mike Tancsa <mike@sentex.net> Cc: freebsd-stable@freebsd.org, Brooks Davis <brooks@freebsd.org>, Dimitry Andric <dim@freebsd.org> Subject: Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9 Message-ID: <CA%2B7WWSfvit0G_LL57e6dU%2BZRWnrgip_pwGUqtSudfu_UPqzkmQ@mail.gmail.com> In-Reply-To: <51081E18.60303@sentex.net> References: <CA%2B7WWSeOpuAv9PL2_G6Z1Q_SLv5xcTjcujiw6Rs8tdBsrLO7wQ@mail.gmail.com> <50F6D20A.6070306@FreeBSD.org> <CA%2B7WWSfE1bAr7GriRGAKBVpkiNE%2Btn-%2Bd0cO3vpNPY-SWxfghg@mail.gmail.com> <20130117001116.GD29437@lor.one-eyed-alien.net> <CA%2B7WWSdW95=qBthPKWtn1uT_FTD2ka-oQXLo-owFEn=kO4GYRg@mail.gmail.com> <50F81588.5020106@FreeBSD.org> <CA%2B7WWSfrpvJXAqrn8d=j1yXZmUw_itxtxJyxYExPnE-JNE2%2Bpw@mail.gmail.com> <51081E18.60303@sentex.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 29, 2013 at 9:08 PM, Mike Tancsa <mike@sentex.net> wrote: > On 1/17/2013 4:35 PM, Kimmo Paasiala wrote: >> On Thu, Jan 17, 2013 at 5:15 PM, Dimitry Andric <dim@freebsd.org> wrote: >>> On 2013-01-17 14:07, Kimmo Paasiala wrote: >>>> >>>> On Thu, Jan 17, 2013 at 2:11 AM, Brooks Davis <brooks@freebsd.org> wrote: >>> >>> ... >>> >>> Please try the following patch, which tells configure that HAVE_STRNVIS >>> is always false. I think this is the easiest way, unless we really want >>> the port to use our own strnvis. >> >> This will still leave the exported symbol in the plugin binary with >> the name strnvis. What would be needed is renaming of the function to >> something else, like pam_ssh_agent_auth_strnvis(), maybe using a macro >> >> #define strnvis pam_ssh_agent_auth_strnvis >> >> somewhere. >> >> I can try my hand on coming up with a fix but its going to take some >> time, the source code of the plugin and not to mention the configure >> script look quite hairy. > > Hi, > Just wondering if anyone ever came up with a patch / work around to this ? > > ---Mike > > > -- Hi, Yes I did in fact but it's a really quick and dirty hack. I renamed the openbsd strnvis to strnvis_local so the symbol in plugin binary won't conflict with strnvis from libc. I'll have to see if I can clean it up and submit a PR with a diff. -Kimmo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2B7WWSfvit0G_LL57e6dU%2BZRWnrgip_pwGUqtSudfu_UPqzkmQ>