Date: Thu, 12 Jul 2012 00:26:15 -0400 From: Henry Hu <henry.hu.sh@gmail.com> To: Doug Barton <dougb@freebsd.org> Cc: ports@freebsd.org, Michael Scheidell <scheidell@freebsd.org>, Eygene Ryabinkin <rea@freebsd.org> Subject: Re: cvs commit: ports/x11/slim Makefile pkg-plist ports/x11/slim/files pam.conf slim.sh.in Message-ID: <CAEJt7hbQwERZuNjmv6G9pKj62rb6d-EjzjVKMmvuSXLHBvzPzA@mail.gmail.com> In-Reply-To: <4FFBD95F.6010209@FreeBSD.org> References: <201207042153.q64Lrajj048759@repoman.freebsd.org> <4FF4BDFC.7070604@FreeBSD.org> <85zFQmwqygMzE5IoVEZOBb55NHc@h%2BKmx6xuhLPDxlAxgYCP%2BNijPgY> <4FF95786.2070905@FreeBSD.org> <20120709081324.GB13540@MacBook-Eygene-Ryabinkin.local> <4FFBD95F.6010209@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I'm testing the patch. First, I failed to build, and the reason is that my cmake is 2.8.3 which is too old. According to http://www.cmake.org/pipermail/cmake-commits/2012-February/012056.html, it seems like that after cmake 2.8.7, find_package(X11) would define X11_Xmu_LIB, but before that, it is defined as GLUT_Xmu_LIBRARY with find_package(GLUT). Do we need to add a build dependency that this depends on cmake >= 2.8.7? It seems like that there is no reference to glut anymore. Its usage was only to find Xmu. So I think that we should remove USE_GL=glut. For the png problem, I think that we can use png_jmpbuf for any libpng >= 1.2.5? It seems to be exist at least from libpng 1.2.5 (http://www.libpng.org/pub/png/libpng-1.2.5-manual.html) so it's safe to use it? According to http://old.nabble.com/png_jmpbuf%28%29-in-libpng-1.4-td30966838.html, someone has problem with png_jmpbuf with libpng 1.4, but it seems like that this is not related. On Tue, Jul 10, 2012 at 3:27 AM, Doug Barton <dougb@freebsd.org> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 07/09/2012 01:13, Eygene Ryabinkin wrote: >> This very error should be fixed by the patch > > Yes, I'm an idiot. :) I successfully applied your patch and forgot to > move the new patch- file into files/. Once I fixed the PEBKAC it worked > as expected on 10-current amd64, and 8-stable i386. > > Henry, if you'd like me to apply the patch just let me know. Eygene, > thanks for doing this. > > Doug > > - -- > > Change is hard. > > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.19 (FreeBSD) > > iQEcBAEBCAAGBQJP+9lfAAoJEFzGhvEaGryEds8H/jVudAimsgQEgJZ1EGWCN7mX > xsjam23cBz5hCAf5ay4cmDkyUbdfSeYJHTQ+WmjuMRKaoKBoyMvKSAbVcvKfOiNr > iOoFWT82D/fXWNW+X/Ny4sqv16FNpP2hQsiEa0E5luPU9bA52wSq6kGU9EiQ+VY6 > JrxwHV8/7MfzaX+g6fRkhwphRYI9bmzK0+evvtMtxEq9dCZTtFcMmGFSwy4EAzT3 > 3mbMYjeWlIsCko+Y/GjtXGlopxiStbMUU32B+O1oKrvtzHJ2Srgi2vZ/B4XVXPSB > W28ANO0AZbqzIUcZvaechXjjcb0mlNKsRnWjlDC4ysheGH6XRjLCEgFH0MZed0I= > =nNUS > -----END PGP SIGNATURE----- -- Cheers, Henry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAEJt7hbQwERZuNjmv6G9pKj62rb6d-EjzjVKMmvuSXLHBvzPzA>