Date: Wed, 18 Sep 2019 07:03:05 -0700 From: vm finance <vm.finance2@gmail.com> To: Randall Stewart <rrs@netflix.com> Cc: =?UTF-8?Q?Michael_T=C3=BCxen?= <michael.tuexen@lurchi.franken.de>, freebsd-net <freebsd-net@freebsd.org>, Jamie Landeg-Jones <jamie@catflap.org>, Ryan Stone <rysto32@gmail.com> Subject: Re: BBR patches? Message-ID: <CAKy-8=gjXXz8VRkxaHXQY4Z%2BJpAkFusFbv_eFnM8huwWZgQD_g@mail.gmail.com> In-Reply-To: <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> References: <CAKy-8=jUu=dbp1s7nhYBwgeh%2BiO-XY-YEnh1MJ81aYJoopVonA@mail.gmail.com> <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <CAKy-8=gZ8E73PZdxb33aN=TmfigcNyTvZP4wP3M-mAy9no-v6w@mail.gmail.com> <CAFMmRNxbX5f3s0ZZk=Epr7Gu7%2Bsjat8F0TV0aX_RwoFgX0s%2ByA@mail.gmail.com> <CAKy-8=g=3LC8u_vc_3_Pfe6pgoUxpvx7N_j=xv7nRaM%2BD1Oz-A@mail.gmail.com> <D35AF884-C631-42CE-ABFD-F4AA76AA6693@netflix.com> <CAKy-8=jSdSFPJWL=cLeea-KSc=9wxR6vQTODibw7-GUh0XpCfw@mail.gmail.com> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <CAKy-8=idqzA0-Trm%2B5gZSQs=vyXrPm40gP3AsbMf_YQj-NEHaA@mail.gmail.com> <CAKy-8=jpGvKU1khALK%2Ba5Ojp7btg7y1W%2BELtTLQaniVNtgBj3g@mail.gmail.com> <AD906F45-B083-476F-952E-3318F36BD828@netflix.com> <BCC20B79-ECEF-4D7C-AA7E-5F8A0869753A@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <CAKy-8=jwoV8=gXXUCCMARe4%2BELuqDXuYY=J9Rn7ej0536xTJvQ@mail.gmail.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <DEA3139A-ED05-47D9-833E-F1631E7185AD@gmail.com> <CAKy-8=gAFZu0wWgWCNwuYDzKcyoLDwHgUPGNA%2BaLCucEfFrgYg@mail.gmail.com> <EE614FCD-C0B1-4934-98A5-F60C5054C077@lurchi.franken.de> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks Randall, Michael, I did "svn svn://svn.freebsd.org/base/head /usr/src" and now doing "make buildworld buildkernel" [I didn't change anything in configs - just whatever are the defaults] I would update as soon as its done. Thanks again! On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart <rrs@netflix.com> wrote: > One other note.. I notice his kernel conf he sent does not have > the right things to get BBR even to attempt to build. > > I would suggest using that config for the first steps.. then he must add > the additional tcp stacks and the hpts in order to get bbr/rack and any > other > extra stack=E2=80=A6. > > But I would suggest to build with his current config first and once he ha= s > that in place and building > > a) apply the patch > b) add the extra kernel options > > R > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart <rrs@netflix.com> wrote: > > > > Thats great idea Michael. > > > > From the look fo the build log I was sent, his blow-up has nothing to d= o > > with the patches. > > > > He should probably > > > > 1) Check out a fresh version of head. > > 2) Follow the instructions in UPDATING to get a clean build. > > =E2=80=94 make buildworld > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf > > > > ** do the reboot and merge master ** > > > > Then after that he could > > > > 3) Apply the current patch in the review > > 4) do build that > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN -DNO_CL= EANDIR > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf > > > > And he should have it all working :) > > > > I have done multiple builds with the latest head from yesterday both > with and without > > the extra stacks and hpts.. and I can=E2=80=99t get a build failure.. t= his would > verify he can > > at least build head.. > > > > R > > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen < > michael.tuexen@lurchi.franken.de> wrote: > >> > >>> On 18. Sep 2019, at 08:19, vm finance <vm.finance2@gmail.com> wrote: > >>> > >>> correcting a typo: > >>> > >>> svn co svn://svn.freebsd.org/base/head /usr/src > >>> current revision: 352434 > >> I suggest to build/install head first without any patches. After that > has worked, > >> apply the patches you are interested in. That way it is easy to > separate generic > >> build issues and issue specific to a patch. > >> > >> Best regards > >> Michael > >>> > >>> Thank you! > >>> > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance <vm.finance2@gmail.com> > wrote: > >>> > >>>> Actually I am on head already as mentioned previously. Pulled it usi= ng > >>>> yesterday: > >>>> > >>>> svn co svn://svn.freebsd.org/base/head /use/src > >>>> > >>>> > >>>> If you could pls let me know the new patch, I can try that. > >>>> > >>>> Thanks > >>>> > >>>> Sent from my iPhone > >>>> > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart <rrs@netflix.com> wrote: > >>>> > >>>> There have been several patches pre-this one that provide > >>>> the infrastructure to support BBR. > >>>> > >>>> Release 12.0 will *not* have these patches and will *not* compile it= . > >>>> > >>>> I have no intention at this point in doing a MFC of this work.. so i= f > you > >>>> want > >>>> to run BBR you need to run Head > >>>> > >>>> R > >>>> > >>>> On Sep 17, 2019, at 7:26 PM, vm finance <vm.finance2@gmail.com> > wrote: > >>>> > >>>> > >>>> Hi Randall, > >>>> > >>>> > >>>> Could you please provide a pointer to the latest patch. I had applie= d > the > >>>> one you published Sep-10. > >>>> > >>>> > >>>> Following is what I have done: > >>>> > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org > >>>> > >>>> 2. Got VM up under VMPlayer on x86 laptop > >>>> > >>>> 3. Checked out latest codebase from freebsd repo: > >>>> > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* > >>>> > >>>> cd /usr/src; > >>>> > >>>> make buildworld buildkernel > >>>> > >>>> [this is where make fails when patch is applied] > >>>> > >>>> > >>>> I could try to build with your latest patch - please send me a > pointer. > >>>> > >>>> > >>>> Thanks for your help! > >>>> > >>>> > >>>> > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart <rrs@netflix.com> > wrote: > >>>> > >>>> Looking at your make file log I can=E2=80=99t really tell what you a= re doing. > >>>> > >>>> > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 > >>>> > >>>> > >>>> Are you cross compiling? > >>>> > >>>> > >>>> I have done the old fashioned kernel make > >>>> > >>>> > >>>> i.e. > >>>> > >>>> > >>>> cd src/sys/amd64/config > >>>> > >>>> config headvm > >>>> > >>>> cd ../compile/headvm > >>>> > >>>> > >>>> make cleandepend ; make depend; make -j3 > >>>> > >>>> > >>>> I have done > >>>> > >>>> > >>>> cd src > >>>> > >>>> make buildkernel KERNCONF=3Dheadvm > >>>> > >>>> > >>>> And even > >>>> > >>>> > >>>> make buildkernel KERNCONF=3DGENERIC > >>>> > >>>> > >>>> to make sure that the build works without bbr. > >>>> > >>>> > >>>> I attach my headvm config.. > >>>> > >>>> > >>>> What exactly are you building and how? kernel config too please? > >>>> > >>>> > >>>> R > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart <rrs@netflix.com> wrote= : > >>>> > >>>> > >>>> looking > >>>> > >>>> > >>>> I was at 352408.. let me update and try it > >>>> > >>>> > >>>> R > >>>> > >>>> > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart <rrs@netflix.com> wrote= : > >>>> > >>>> > >>>> Hmm > >>>> > >>>> > >>>> Did you get the patch I updated too this am? > >>>> > >>>> > >>>> I have built it both with and without the bbr stack and had no issue= .. > >>>> there was > >>>> > >>>> an issue with KTLS before the update though. > >>>> > >>>> > >>>> I don=E2=80=99t recognize what you have below there though=E2=80=A6 > >>>> > >>>> > >>>> R > >>>> > >>>> > >>>> On Sep 17, 2019, at 11:47 AM, vm finance <vm.finance2@gmail.com> > wrote: > >>>> > >>>> > >>>> Got it - thank you! > >>>> > >>>> > >>>> btw, I tried to build the patch but its giving an error. Following i= s > SVN > >>>> info + make error mesg. > >>>> > >>>> > >>>> Please let me know what am I missing here? > >>>> > >>>> > >>>> Thanks! > >>>> > >>>> > >>>> #svnlite revision > >>>> > >>>> Path: . > >>>> > >>>> Working Copy Root Path: /usr/src > >>>> > >>>> URL: svn://svn.freebsd.org/base/head > >>>> > >>>> Relative URL: ^/head > >>>> > >>>> Repository Root: svn://svn.freebsd.org/base > >>>> > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > >>>> > >>>> Revision: 352436 > >>>> > >>>> Node Kind: directory > >>>> > >>>> Schedule: normal > >>>> > >>>> Last Changed Author: jah > >>>> > >>>> Last Changed Rev: 352434 > >>>> > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > >>>> > >>>> > >>>> root@osboxes:/usr/src # > >>>> > >>>> > >>>> -------------------------------------------- snip > >>>> ---------------------------- > >>>> > >>>> > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > >>>> > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > >>>> > >>>> =3D=3D=3D> sys (cleandir) > >>>> > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h > >>>> opt_kern_tls.h > >>>> > >>>> rm: x86: is a directory > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make[3]: stopped in /usr/src/sys > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make[2]: stopped in /usr/src > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make[1]: stopped in /usr/src > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make: stopped in /usr/src > >>>> > >>>> > >>>> > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance <vm.finance2@gmail.com> > wrote: > >>>> > >>>> Got it - thank you! > >>>> > >>>> > >>>> btw, I tried to build the patch but its giving an error. Following i= s > SVN > >>>> info + make error mesg. > >>>> > >>>> I have also attached the entire build log...snippet is below > >>>> > >>>> > >>>> Please let me know what am I missing here? > >>>> > >>>> > >>>> Thanks! > >>>> > >>>> > >>>> #svnlite revision > >>>> > >>>> Path: . > >>>> > >>>> Working Copy Root Path: /usr/src > >>>> > >>>> URL: svn://svn.freebsd.org/base/head > >>>> > >>>> Relative URL: ^/head > >>>> > >>>> Repository Root: svn://svn.freebsd.org/base > >>>> > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > >>>> > >>>> Revision: 352436 > >>>> > >>>> Node Kind: directory > >>>> > >>>> Schedule: normal > >>>> > >>>> Last Changed Author: jah > >>>> > >>>> Last Changed Rev: 352434 > >>>> > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > >>>> > >>>> > >>>> root@osboxes:/usr/src # > >>>> > >>>> > >>>> -------------------------------------------- snip > >>>> ---------------------------- > >>>> > >>>> > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > >>>> > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > >>>> > >>>> =3D=3D=3D> sys (cleandir) > >>>> > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h > >>>> opt_kern_tls.h > >>>> > >>>> rm: x86: is a directory > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make[3]: stopped in /usr/src/sys > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make[2]: stopped in /usr/src > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make[1]: stopped in /usr/src > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make: stopped in /usr/src > >>>> > >>>> > >>>> > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart <rrs@netflix.com> > wrote: > >>>> > >>>> Pacing is provided by tcp_hpts.c. The current linux patches do not > have > >>>> > >>>> to have fq.. they built an alternate means of doing pacing into bbr. > >>>> > >>>> > >>>> In either case our testing has shown that our pacing is more accurat= e > than > >>>> > >>>> either fq or the internal pacer :) > >>>> > >>>> > >>>> R > >>>> > >>>> > >>>> On Sep 17, 2019, at 11:05 AM, vm finance <vm.finance2@gmail.com> > wrote: > >>>> > >>>> > >>>> Thanks Randall. > >>>> > >>>> I was able to apply the patch - now rebuilding the kernel. Would > update on > >>>> how it goes. > >>>> > >>>> > >>>> BTW, is there any description on how lack of tc_fq under FreeBSD is > >>>> compensated here? > >>>> > >>>> The original BBR patches on Linux show that as a must-have? Is that > >>>> functionality implemented via tcp_ratelimit.[ch]? > >>>> > >>>> > >>>> Any pointers to existing presentations/discussions highly appreciate= d? > >>>> > >>>> > >>>> Thanks a lot. > >>>> > >>>> > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart <rrs@netflix.com> > wrote: > >>>> > >>>> You should be able to compile it against the current head. I re-doin= g > that > >>>> now (had an > >>>> > >>>> issue with my machine and had to roll it back to a backup). > >>>> > >>>> > >>>> When I put the patch up on Sept 10th it complied with and without BB= R > on > >>>> whatever > >>>> > >>>> was that rev.. > >>>> > >>>> > >>>> Looking in the commit logs that would have been around 352191 > >>>> > >>>> > >>>> Hope that helps > >>>> > >>>> > >>>> R > >>>> > >>>> > >>>> On Sep 17, 2019, at 3:32 AM, vm finance <vm.finance2@gmail.com> > wrote: > >>>> > >>>> > >>>> Hi Randall, > >>>> > >>>> > >>>> Thanks for releasing BBR patch: > >>>> > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > >>>> > >>>> > >>>> Could you please let me know what SVN/GIT label tag this is based on= ? > I > >>>> would like to patch and experiment with it. I couldn't find this inf= o > in > >>>> the released patch. > >>>> > >>>> > >>>> Thanks a lot! > >>>> > >>>> > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone <rysto32@gmail.com> > wrote: > >>>> > >>>> rrs@ has just posted the BBR patch to phabricator: > >>>> > >>>> > >>>> https://reviews.freebsd.org/D21582 > >>>> > >>>> > >>>> ------ > >>>> > >>>> Randall Stewart > >>>> > >>>> rrs@netflix.com > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> ------ > >>>> > >>>> Randall Stewart > >>>> > >>>> rrs@netflix.com > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> ------ > >>>> > >>>> Randall Stewart > >>>> > >>>> rrs@netflix.com > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> ------ > >>>> > >>>> Randall Stewart > >>>> > >>>> rrs@netflix.com > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> ------ > >>>> > >>>> Randall Stewart > >>>> > >>>> rrs@netflix.com > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> ------ > >>>> Randall Stewart > >>>> rrs@netflix.com > >>>> > >>>> > >>>> > >>>> > >>> _______________________________________________ > >>> freebsd-net@freebsd.org mailing list > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net > >>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org= " > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > > > ------ > Randall Stewart > rrs@netflix.com > > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKy-8=gjXXz8VRkxaHXQY4Z%2BJpAkFusFbv_eFnM8huwWZgQD_g>