Date: Fri, 05 Apr 2002 15:39:13 +0200 From: Philipp Mergenthaler <un1i@rz.uni-karlsruhe.de> To: freebsd-hackers@FreeBSD.ORG Cc: maxim@macomnet.ru Subject: Re: cdcontrol(1) speed command Message-ID: <E16tTvt-0002NJ-00@rzstud1.rz.uni-karlsruhe.de> In-Reply-To: <20020405145853.O45449-100000@news1.macomnet.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
In article <20020405145853.O45449-100000@news1.macomnet.ru> you wrote: > Here is a patch for cdcontrol(1) to allow set maximum CD drive speed. > It comes from kern/35512. Are there any comments/objections? > Index: cdcontrol.1 > =================================================================== > RCS file: /home/ncvs/src/usr.sbin/cdcontrol/cdcontrol.1,v > retrieving revision 1.32 > diff -u -r1.32 cdcontrol.1 > --- cdcontrol.1 15 Jul 2001 08:01:46 -0000 1.32 > +++ cdcontrol.1 27 Mar 2002 10:57:34 -0000 > @@ -154,6 +154,9 @@ > Set minute-second-frame ioctl mode (default). > .It Cm set Ar lba > Set LBA ioctl mode. > +.It Cm speed Ar s > +Set the highest speed that the drive should use. This command is currently > +only supported on ATAPI drives. Maybe we should mention the unit for speed here, i.e. "kB/s" or "multiples of single speed", but that depends on whether kern/35512 will be accepted or not. [...] > +++ cdcontrol.c 27 Mar 2002 10:58:12 -0000 > @@ -24,6 +24,7 @@ > #endif /* not lint */ > #include <sys/cdio.h> > +#include <sys/cdrio.h> Jörg Wunsch commented that adding "include <sys/cdrio.h>" would be wrong and that this ioctl should be moved to sys/cdio.h instead. (I guess then it should be renamed to CDIOCREADSPEED, too.) This would then have to be changed in src/sys/dev/ata/atapi-cd.c, too. Bye, Philipp -- http://www.uni-karlsruhe.de/~un1i/ (,.) \\\@@ ) \= ) cc_|\_,^ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E16tTvt-0002NJ-00>