Date: 04 Jul 2002 00:25:49 +0300 From: Ville =?ISO-8859-1?Q?Skytt=E4?= <scop@FreeBSD.org> To: Khachaturov Vassilii <Vassilii.Khachaturov@comverse.com> Cc: "'cvsweb development'" <freebsd-cvsweb@FreeBSD.org> Subject: Re: FW: [PATCH] fileSortCmp() should properly weed out rogue non-dir files Message-ID: <1025731551.5927.119.camel@bobcat.ods.org> In-Reply-To: <6B1DF6EEBA51D31182F200902740436803B24BB5@mail-in.comverse.com> References: <6B1DF6EEBA51D31182F200902740436803B24BB5@mail-in.comverse.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2002-07-03 at 18:13, Khachaturov Vassilii wrote: > By knu's request, I am resubmitting the patch to this new mailing list. > (This is my 7th patch to cvsweb, but just the 1st one submitted here - > please > tell me if another patch format/attachment way is preferred on the list...) Both are fine with me, but it seems inlining works better with the archives as you already noticed. > BTW, the README et al. stuff in the project source should probably be > updated to refer to this list, as should be the default footer/header > project > info - right now it suggests posting changes directly to knu@freebsd.org. Yes, I already had a patch waiting, and it was committed a while ago. > P.P.S. For ChangeLog purposes, please use my other address Got that... > Subject: [PATCH] fileSortCmp() should properly weed out rogue non-dir files > > > ...otherwise the sorting order, if it is not name-base, is messed up. > > If your repository has no non-,v files in the repository subdirs, > > (no lock files etc.) then you aren't affected by this fix because you > > don't have the problem in the 1st place :-) Over here, I was mad at > > the occasional sort order breakage until I finally decided to debug it > > and noticed what's going on in the comparison routine by adding a > > trace there during the debug. > > > > When rogue files are present, all sort orders were affected, except > > the one based on the file name. Could you shed a bit more light on this, I can't verify the problem here. I'm unable to get non-,v files in the repo dirs to show up in CVSweb's directory listings or the sort orders to break... -\/ille To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-cvsweb" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1025731551.5927.119.camel>