Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Dec 1996 04:12:32 +1100
From:      Bruce Evans <bde@zeta.org.au>
To:        bde@zeta.org.au, sos@ravenock.cybercity.dk
Cc:        cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, sos@freefall.freebsd.org
Subject:   Re: cvs commit:  src/sys/kern subr_diskslice.c src/sbin/i386/fdisk fdisk.c src/sys/ufs/ufs ufs_disksubr.c src/sys/scsi od.c sd.cO
Message-ID:  <199612011712.EAA27211@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>> >  Modified:    sys/kern  subr_diskslice.c
>> >               sys/ufs/ufs  ufs_disksubr.c
>> >               sys/scsi  od.c sd.c
>> >               sbin/i386/fdisk  fdisk.c
>> >               sbin/newfs  mkfs.c newfs.c
>> >  Log:
>> >  This update adds the support for != 512 byte sector SCSI devices to
>> 
>> Urk.  This version does the scaling in the wrong place.  The scaling
>
>This works for me, but feel free to change it to something better....

It has a serious problem: od.c and sd.c break the the EOF handling by
restoring bp->b_bcount.  It is now possible to write beyond the end of
a slice or partition.  This can probably be fixed quickly by rescaling
bp->b_bcount instead of restoring it (the same as for bp->b_resid).  I
don't have time to test this now.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199612011712.EAA27211>